Hi Petter / Michael.
Thanks for your review comments.
On Fri, 11 Nov 2022 at 18:26, Peter Geis <pgwipeout@xxxxxxxxx> wrote:
>
> On Fri, Nov 11, 2022 at 4:43 AM Anand Moon <linux.amoon@xxxxxxxxx> wrote:
> >
> > On rk356x ethernet phy support reduced media independent interface (RMII)
> > and reduced gigabit media independent interface (RGMII).
> > So set the phy mode to rgmii.
>
> The RTL8211 supports rgmii-id just fine, you only need to go to rgmii
> on these boards if you need to tune the delays manually.
Ok rgmii supports internal rx and tx clock delay
whereas rgmii-id does not supports internal clock delay.
>
> >
> > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> > index ea74ba32fbbd..72e410e3aca8 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> > @@ -253,7 +253,7 @@ &gmac1 {
> > assigned-clock-rates = <0>, <125000000>;
> > clock_in_out = "output";
> > phy-handle = <&rgmii_phy1>;
> > - phy-mode = "rgmii-id";
> > + phy-mode = "rgmii";
>
> You should be setting the delay tuning in this patch as well.
I will try to fix this in the next version.
>
> > pinctrl-names = "default";
> > pinctrl-0 = <&gmac1m1_miim
> > &gmac1m1_tx_bus2
> > --
> > 2.38.1
Thanks
-Anand
