On Tue, Nov 15, 2022 at 05:02:42PM +0000, Srinivas Kandagatla wrote: > Add support for SoundCard on X13s. This patch adds support for Headset > Playback, record and 2 DMICs on the Panel along with the regulators > required for powering up the LPASS codecs. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > --- > .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 213 ++++++++++++++++++ > 1 file changed, 213 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index b2b744bb8a53..99c3021e8149 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -58,6 +58,16 @@ vreg_misc_3p3: regulator-misc-3p3 { > regulator-boot-on; > regulator-always-on; > }; > + > + vph_pwr: vph-pwr-regulator { Use "regulator-" as a name prefix, and add "vreg_" as label prefix for consistency: vreg_vph_pwr: regulator-vph-pwr { > + compatible = "regulator-fixed"; > + regulator-name = "VPH_VCC3R9"; > + regulator-min-microvolt = <3900000>; > + regulator-max-microvolt = <3900000>; > + > + regulator-always-on; > + regulator-boot-on; > + }; > }; Johan