Re: [PATCH v7 4/7] ARM: dts: Enable Broadcom Cygnus SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Thanks for the review. Will send out v8 version. Hopefully for finally approval.

On 14-10-28 09:10 AM, Arnd Bergmann wrote:
On Wednesday 22 October 2014 13:57:51 Scott Branden wrote:
+
+       aliases {
+               serial0 = &uart3;
+               serial1 = &uart0;
+       };
+
+       chosen {
+               bootargs = "console=ttyS0,115200 earlyprintk debug";
+       };


Please move the 'aliases' and 'chosen' node into the .dts files, these
are board specific, not SoC specific.
ok.

For chosen, please remove earlyprintk and debug, which don't normally
make sense unless you are debugging, and which will break in a multiplatform
kernel.
ok.

Please also add an "stdout-path = &uart3" property in chosen so that
earlycon can work. Note that earlycon is currently broken on arm32,
but we'll get there.
ok.

	Arnd


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux