On 16/11/2022 00:37, Alex Helms wrote: > Add dt bindings for the Renesas ProXO oscillator. > > Signed-off-by: Alex Helms <alexander.helms.jy@xxxxxxxxxxx> > --- > .../bindings/clock/renesas,proxo.yaml | 51 +++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/renesas,proxo.yaml > > diff --git a/Documentation/devicetree/bindings/clock/renesas,proxo.yaml b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml > new file mode 100644 > index 000000000..ff960196d > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/renesas,proxo.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas ProXO Oscillator Device Tree Bindings Same comments as for your other patch. All the same... > + > +maintainers: > + - Alex Helms <alexander.helms.jy@xxxxxxxxxxx> > + > +description: > + Renesas ProXO is a family of programmable ultra-low phase noise > + quartz-based oscillators. > + > +properties: > + '#clock-cells': > + const: 0 > + > + compatible: > + enum: > + - renesas,proxo-xp > + > + reg: > + maxItems: 1 > + > + clock-output-names: > + maxItems: 1 > + > + renesas,crystal-frequency-hz: > + description: Internal crystal frequency, default is 50000000 (50MHz) If it is internal, then it is fixed, right? Embedded in the chip, always the same. Why do you need to specify it? Best regards, Krzysztof