On Wed, Nov 16, 2022, at 07:53, Yinbo Zhu wrote: > The latest Loongson series platform use dts or acpi framework to > register gpio device resources, such as the Loongson-2 series > SoC of LOONGARCH architecture. In order to support dts, acpi and > compatibility with previous platform device resources in driver, > this patch was added. I think the support for legacy platform_data should be left out of this patch. I am working on a series that removes unused platform_data headers for machines that have DT support and no longer use static platform_device declarations anywhere in the kernel, so if you add another instance, that would just get removed again in the near future. Just don't add it here. If there are users that use traditional boardfiles instead of DT, they already need kernel patches to add the board files, and adding in the driver support can be part of the same patches. Arnd