On Tue, Nov 15, 2022 at 11:16:53AM +0000, Mark Brown wrote: > On Tue, Nov 15, 2022 at 10:42:50AM +0000, Russell King (Oracle) wrote: > > On Tue, Nov 15, 2022 at 10:34:41AM +0000, Mark Brown wrote: > > > > Well, it's not making this maintainer happy :/ If we know what > > > PHY is there why not just look up the set of supplies based on > > > the compatible of the PHY? > > > It looks to me like this series fetches the regulators before the PHY > > is bound to the driver, so what you're proposing would mean that the > > core PHY code would need a table of all compatibles (which is pretty > > hard to do, they encode the vendor/device ID, not some descriptive > > name) and then a list of the regulator names. IMHO that doesn't scale. > > Oh, PHYs have interesting enough drivers to dynamically load > here? The last time I was looking at MDIO stuff it was all > running from generic class devices but that was quite a while > ago. There's a couple of generic drivers which are used if there isn't a specific driver available for the vendor/device ID that has either been probed from the hardware, or discovered encoded in the firmware's compatible property. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
