Re: [PATCH v4 2/9] dt-bindings: rtc: mediatek: convert MT6397 rtc documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, thanks for your help

I checked and it doesn't support it but this needs to be fixed. >>>> >>>>> What about rest of rtc.yaml schema? >>>>> >>>> >>>>
wakeup-source would make sense but the driver doesn't support it yet. >>> >>> The question is about hardware - does hardware support waking up the >>> system via interrupt? This is usually a domain of PMICs which still are >>> powered on when system sleeps. >>> >> >> I'd say that it is possible that a PMIC is able to wake up the system >> with or without having an interrupt wired to the SoC so wakeup-source >> makes sense. We don't need it if it is interrupt only. >
Then I propose to reference the rtc.yaml.

I think I understand my error.
Actually, the RTC (HW) support the "start-year" feature, then I suggest
to fix the binding like that:

allOf:
  - $ref: "rtc.yaml#"

properties:
  compatible:
    enum:
      - mediatek,mt6323-rtc
      - mediatek,mt6357-rtc
      - mediatek,mt6358-rtc
      - mediatek,mt6366-rtc
      - mediatek,mt6397-rtc

  start-year: true

additionalProperties: false

required:
  - compatible

examples:
  - |
    pmic {
        rtc {
            compatible = "mediatek,mt6397-rtc";
        };
    };




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux