On 12/11/2022 15:34, Maya Matuszczyk wrote:
> This device is another revision of Odroid Go Advance, with added two
> volume buttons, a second analog stick and a bigger screen that isn't yet
> supported in the Mainline Kernel.
>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@xxxxxxxxx>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3326-odroid-go3.dts | 161 ++++++++++++++++++
> 2 files changed, 162 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3326-odroid-go3.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 12446f531d29..142c83d2e5aa 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -9,6 +9,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3308-rock-pi-s.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3318-a95x-z2.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3326-odroid-go2.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3326-odroid-go2-v11.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3326-odroid-go3.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-a1.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-evb.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-nanopi-r2s.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go3.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go3.dts
> new file mode 100644
> index 000000000000..4b6c896d8abd
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go3.dts
> @@ -0,0 +1,161 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2019 Hardkernel Co., Ltd
> + * Copyright (c) 2020 Theobroma Systems Design und Consulting GmbH
> + * Copyright (c) 2022 Maya Matuszczyk <maccraft123mc@xxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +#include "rk3326-odroid-go.dtsi"
> +
> +/ {
> + model = "ODROID-GO Super";
> + compatible = "hardkernel,rk3326-odroid-go3", "rockchip,rk3326";
> +
> + joystick_mux_controller: mux-controller {
> + status = "okay";
Why adding status? Also, it's not a first property...
> + compatible = "gpio-mux";
> + pinctrl = <&mux_en_pins>;
> + #mux-control-cells = <0>;
> +
> + mux-gpios = <&gpio3 RK_PB3 GPIO_ACTIVE_LOW>,
> + <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>;
> + };
> +
> + joystick_mux: adc-mux {
> + status = "okay";
Why status? Is it a node override?
> + compatible = "io-channel-mux";
> + io-channels = <&saradc 1>;
> + io-channel-names = "parent
Best regards,
Krzysztof
