Hi Vyacheslav, On Thu, Nov 10, 2022 at 4:01 PM Vyacheslav Bocharov <adeep@xxxxxxxxx> wrote: [...] > +- amlogic,mmc-phases: 3-element array of clock phases for core, tx, rx clock with values: > + 0: CLK_PHASE_0 - 0 phase > + 1: CLK_PHASE_90 - 90 phase > + 2: CLK_PHASE_180 - 180 phase > + 3: CLK_PHASE_270 - 270 phase As mentioned in another patch: I'd go with the human readable values (0, 90, 180, 270) instead of the register bits. [...] > + amlogic,mmc-phases = <CLK_PHASE_180 CLK_PHASE_0 CLK_PHASE_0>; Also I *think* the format here is not correct, for an array of three u32 values this should be: amlogic,mmc-phases = <CLK_PHASE_180>, <CLK_PHASE_0>, <CLK_PHASE_0>; Best regards, Martin
