On Fri, Nov 11, 2022 at 02:40:21PM -0600, Bjorn Andersson wrote:
> On Fri, Nov 11, 2022 at 05:27:46PM +0100, Johan Hovold wrote:
> > On Thu, Nov 10, 2022 at 05:05:13PM +0530, Manivannan Sadhasivam wrote:
> > > On Thu, Nov 10, 2022 at 11:35:55AM +0100, Johan Hovold wrote:
> > > > Enable the Qualcomm QCNFA765 Wireless Network Adapter connected to
> > > > PCIe4.
> > > >
> > > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > > > ---
> > > > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 65 +++++++++++++++++++++++
> > > > 1 file changed, 65 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > > > index 5b9e37a16f9f..ab5b0aadeead 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > > > @@ -81,6 +81,22 @@ vreg_misc_3p3: regulator-misc-3p3 {
> > > > regulator-always-on;
> > > > };
> > > >
> > > > + vreg_wlan: regulator-wlan {
> > > > + compatible = "regulator-fixed";
> > > > +
> > > > + regulator-name = "VCC_WLAN_3R9";
> > > > + regulator-min-microvolt = <3900000>;
> > > > + regulator-max-microvolt = <3900000>;
> > > > +
> > > > + gpio = <&pmr735a_gpios 1 GPIO_ACTIVE_HIGH>;
> > > > + enable-active-high;
> > > > +
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&hastings_reg_en>;
> > >
> > > Hastings is the family name of QCA639x WLAN chipsets. I don't think it would be
> > > applicable here. Please use "wlan_reg_en" as that matches the convention used
> > > throughout this file.
> >
> > The pin name here comes from the schematics, which is what we should use
> > for naming when we can.
If hastings is what mentioned in the schematics then it is fine (I can see that
now). For a moment I thought it came from downstream...
Thanks,
Mani
> >
>
> Following the naming in the schematics is the right thing to do.
>
> Regards,
> Bjorn
--
மணிவண்ணன் சதாசிவம்
