On Tuesday, October 28, 2014 08:32:45 AM Caesar Wang wrote: > Dmitry, > > 在 2014年10月28日 08:29, Dmitry Torokhov 写道: > > On Mon, Oct 27, 2014 at 10:39:45AM +0800, Caesar Wang wrote: > >> This add the necessary binding documentation for the thermal > >> found on Rockchip SoCs > >> > >> Signed-off-by: zhaoyifeng <zyf@xxxxxxxxxxxxxx> > >> Signed-off-by: Caesar Wang <caesar.wang@xxxxxxxxxxxxxx> > >> --- > >> > >> .../bindings/thermal/rockchip-thermal.txt | 53 > >> ++++++++++++++++++++++ 1 file changed, 53 insertions(+) > >> create mode 100644 > >> Documentation/devicetree/bindings/thermal/rockchip-thermal.txt>> > >> diff --git > >> a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > >> b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt new > >> file mode 100644 > >> index 0000000..d5b1401 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > >> @@ -0,0 +1,53 @@ > >> +* Temperature Sensor ADC (TSADC) on rockchip SoCs > >> + > >> +Required properties: > >> +- compatible : "rockchip,rk3288-tsadc" > >> +- reg : physical base address of the controller and length of memory > >> mapped + region. > >> +- interrupts : The interrupt number to the cpu. The interrupt specifier > >> format + depends on the interrupt controller. > >> +- clocks : Must contain an entry for each entry in clock-names. > >> +- clock-names : Shall be "tsadc" for the converter-clock, and "apb_pclk" > >> for + the peripheral clock. > >> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a > >> description.> > > I think you are missing description of hw-shut-temp, tsadc-tshut-mode > > and tsadc-tshut-mode > > > > and optional pinctrl settings. > > If it's really need,we just have hw-shut-temp,tsadc-tshut-mode > and tsadc-tshut-mode,no need pinctrl setting,I think. This is more question to DeviceTree guys, but I can see us not documenting pinctrl since it is generic property used by every driver out there. We should definitely document driver-specific properties. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
