Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/27/2014 03:43 PM, Borislav Petkov wrote:
On Mon, Oct 27, 2014 at 01:50:24PM -0500, Thor Thayer wrote:
Do you have any comments about this driver?
Just a question: why do you have three .c files for something which
does only error injection and nothing else AFAICT? Why isn't this part
of altera_edac.c?

There are 2 files for doing the error injection (altera_l2_edac.c and altera_ocram_edac.c) and then 1 file for the irq handling and probe (altera_edac_mgr.c).

The L2 cache and the On-Chip RAM drivers were based on the Calxeda L2 cache driver and when written as 2 separate files, the resulting code was very similar from the probe and error handling standpoint so the common code was combined (altera_edac_mgr.c).

The Memory Controller model was used for the SDRAM EDAC (altera_edac.c) since it matches the DIMM model. The MC model didn't seem to fit the discrete memories like OCRAM and L2 cache (these files) so I used the EDAC device model which agreed with the Calxeda L2 cache driver.

Should I move the EDAC Device probe and error handling from altera_edac_mgr.c to altera_edac.c? Can I mix the MC and Device models in the same file?

Thanks for reviewing and for commenting.

Thor
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux