On 10/11/2022 23:39, Konrad Dybcio wrote:
> Add a device tree for the Xperia 5 IV (pdx224). It's literally the 1 IV
> with a smaller body, different panel, one camera lens (not sensor afaict)
> swapped out and no 3D iToF sensor, hence the device-specific DT is tiny.
>
Thank you for your patch. There is something to discuss/improve.
> +
> +/ {
> + model = "Sony Xperia 5 IV";
> + compatible = "sony,pdx224", "qcom,sm8450";
> +
> + imx563_vdig_vreg: imx563-vdig-vreg {
Please keep consistent suffixes/prefixes for regulators. I think other
file is using "-regulator", not "-vreg",
Best regards,
Krzysztof
