On Wed, 9 Nov 2022 at 14:12, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > PMK8350 is shipped on SID6 with some SoCs, for example with SM6375. > Add a DT with the SID changed to allow it to work. > > Unfortunately, the entire DT needs to be copied even if the diff is > very little, as the node names are not unique. Including pm6125 and > pmk8350 together for example, would make pmk8350 overwrite the pm6125 > node, as both are defined as 'pmic@0'. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/pmk8350_sid6.dtsi | 73 ++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/pmk8350_sid6.dtsi Just to throw my 2c. If I was doing this myself, I'd allow pmk8350 to receive external SID using the cpp #define (And to default to 0 if one didn't use it). -- With best wishes Dmitry