On 09/11/2022 10:12, Russell King (Oracle) wrote: > On Wed, Nov 09, 2022 at 09:36:12AM +0100, Krzysztof Kozlowski wrote: >> On 08/11/2022 23:09, Russell King (Oracle) wrote: >>> On Tue, Nov 08, 2022 at 09:56:40PM +0100, Krzysztof Kozlowski wrote: >>>> On 08/11/2022 17:33, Russell King (Oracle) wrote: >>>>> Add the DT binding for the Apple Mac System Management Controller GPIOs. >>>>> >>>>> Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> >>>>> --- >>>>> .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ >>>>> 1 file changed, 37 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml b/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml >>>>> new file mode 100644 >>>>> index 000000000000..1a415b78760b >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml >>>>> @@ -0,0 +1,37 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml# >>>> >>>> Does not look like you tested the bindings. Please run `make >>>> dt_binding_check` (see >>>> Documentation/devicetree/bindings/writing-schema.rst for instructions). >>> >>> Oh ffs. DT bindings are utterly impossible to get correct. >> >> Why? You write, you test and then you see the error. Srsly... > > It's utterly impossible for me to remember the dependencies. It's > utterly impossible for me to remember the make incantation to test > this bloody things - especially as I need to limit it otherwise it > takes a very long time to test. Then this is where I can help - you can test just one, specific binding or few of them: make dt_binding_check DT_SCHEMA_FILES=apple,smc-gpio.yaml make dt_binding_check DT_SCHEMA_FILES=apple,smc So before you format patches, just do `git rebase -i HEAD~7`, change to re-word or edit and go one-by-one testing your bisectability. The same we are always doing for regular kernel builds when having a big patchset, right? Each commit must compile, not just the last one in patchset. Or push each of the commit to a service which can do it for you. For example, for kernel building (not yet ready for DT binding check) I am using something like: https://github.com/krzk/tools/tree/master/git-build-kernel > > The whole bloody thing is just too sodding difficult. > > I'm not going to bother with this patch set any more. Too frustrated > with this piecemeal approach and the crappy slow tooling and the > idiotic incomprehensible error messages it spits out. Best regards, Krzysztof
