I just rebased onto the latest master and here's what I got: (base) nroth@nroth-pc:~/linux$ perl scripts/get_maintainer.pl Documentation/devicetree/bindings/media/i2c/ov8858.yaml Nicholas Roth <nicholas@xxxxxxxxxxxxx> (odd fixer:OMNIVISION OV8858 SENSOR DRIVER,commit_signer:1/1=100%,authored:1/1=100%,in file) Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> (maintainer:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)) Rob Herring <robh+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-media@xxxxxxxxxxxxxxx (open list:OMNIVISION OV8858 SENSOR DRIVER) devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-kernel@xxxxxxxxxxxxxxx (open list) Is this just your way of saying that I forgot Mauro or was there something else too? Thanks for the catch-- indeed, I did. > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): Well, that's embarrassing... I forgot to commit before running git-send-email. Also, great to know about the linter! Indeed, there were still some errors on my latest branch. Thanks for bearing with me for now :). Sending a v2... On Tue, Nov 8, 2022 at 6:54 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > > On Mon, 07 Nov 2022 21:38:13 -0600, Nicholas Roth wrote: > > Add a device tree binding for the Omnivision OV8858 image sensor. > > The OV8858 is an 8 megapixel image sensor which provides images in RAW > > format over MIPI CSI-2 data bus and is controlled through an > > I2C-compatibile SCCB bus. > > > > Tested on PinePhone Pro with libcamera cam and qcam. > > > > Signed-off-by: Nicholas Roth <nicholas@xxxxxxxxxxxxx> > > --- > > .../bindings/i2c/ovti,ov8858-i2c.yaml | 78 +++++++++++++++++++ > > 1 file changed, 78 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/i2c/ovti,ov8858-i2c.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/ovti,ov8858-i2c.yaml: properties:compatible: 'ovti,ov8858' is not of type 'object', 'boolean' > from schema $id: http://json-schema.org/draft-07/schema# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/ovti,ov8858-i2c.yaml: 'maintainers' is a required property > hint: Metaschema for devicetree binding documentation > from schema $id: http://devicetree.org/meta-schemas/base.yaml# > ./Documentation/devicetree/bindings/i2c/ovti,ov8858-i2c.yaml: $id: relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/i2c/ovti,ov8858-i2c.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/ovti,ov8858-i2c.yaml: ignoring, error in schema: properties: compatible > Error: Documentation/devicetree/bindings/i2c/ovti,ov8858-i2c.example.dts:27.37-38 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/i2c/ovti,ov8858-i2c.example.dtb] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1492: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
