Hi Geert, On Tue, Nov 8, 2022 at 7:20 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Tue, Nov 8, 2022 at 6:23 PM Lad, Prabhakar > <prabhakar.csengg@xxxxxxxxx> wrote: > > On Tue, Nov 8, 2022 at 4:12 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > > On Tue, Nov 8, 2022 at 5:07 PM Lad, Prabhakar > > > <prabhakar.csengg@xxxxxxxxx> wrote: > > > > On Tue, Nov 8, 2022 at 3:52 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > > > > On Fri, Oct 28, 2022 at 6:59 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > > > > > > > Enable Renesas RZ/Five SoC config in defconfig. It allows the default > > > > > > upstream kernel to boot on RZ/Five SMARC EVK board. > > > > > > > > > > > > Alongside enable SERIAL_SH_SCI config so that the serial driver used by > > > > > > RZ/Five SoC is built-in. > > > > > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > > > --- > > > > > > v4 -> v5 > > > > > > * No change > > > > > > > > > > > > v3 -> v4 > > > > > > * Explicitly enabled ARCH_R9A07G043 config (note I have restored the RB > > > > > > tags with this change) > > > > > > * Used riscv instead of RISC-V in subject line > > > > > > > > > > Thanks for the update! > > > > > > > > > > > --- a/arch/riscv/configs/defconfig > > > > > > +++ b/arch/riscv/configs/defconfig > > > > > > @@ -29,6 +29,8 @@ CONFIG_SOC_MICROCHIP_POLARFIRE=y > > > > > > CONFIG_SOC_SIFIVE=y > > > > > > CONFIG_SOC_STARFIVE=y > > > > > > CONFIG_SOC_VIRT=y > > > > > > +CONFIG_ARCH_RENESAS=y > > > > > > +CONFIG_ARCH_R9A07G043=y > > > > > > > > > > You forgot to refresh after moving ARCH_RENESAS in v5 of "riscv: > > > > > Kconfig.socs: Add ARCH_RENESAS kconfig option", and after relying on > > > > > ARCH_R9A07G043 in drivers/soc/renesas/Kconfig. > > > > > > > > > Sorry I missed your point here, could you please elaborate. > > > > > > I mean that the options have moved, so you should update > > > your patch like this: > > > > > Ouch got that. > > > > > --- a/arch/riscv/configs/defconfig > > > +++ b/arch/riscv/configs/defconfig > > > @@ -26,11 +26,10 @@ CONFIG_EXPERT=y > > > # CONFIG_SYSFS_SYSCALL is not set > > > CONFIG_PROFILING=y > > > CONFIG_SOC_MICROCHIP_POLARFIRE=y > > > +CONFIG_ARCH_RENESAS=y > > > CONFIG_SOC_SIFIVE=y > > > CONFIG_SOC_STARFIVE=y > > > CONFIG_SOC_VIRT=y > > > -CONFIG_ARCH_RENESAS=y > > > -CONFIG_ARCH_R9A07G043=y > > > CONFIG_SMP=y > > > CONFIG_HOTPLUG_CPU=y > > > CONFIG_PM=y > > > @@ -163,6 +159,7 @@ CONFIG_MAILBOX=y > > > CONFIG_RPMSG_CHAR=y > > > CONFIG_RPMSG_CTRL=y > > > CONFIG_RPMSG_VIRTIO=y > > > +CONFIG_ARCH_R9A07G043=y > > > CONFIG_EXT4_FS=y > > > CONFIG_EXT4_FS_POSIX_ACL=y > > > CONFIG_EXT4_FS_SECURITY=y > > > > > > > > > CONFIG_SMP=y > > > > > > CONFIG_HOTPLUG_CPU=y > > > > > > CONFIG_PM=y > > > > > > > > > > PM and GPIOLIB are auto-selected by ARCH_R9A07G043 (through ARCH_RZG2L) > > > > > resp. SOC_RENESAS, so they can be dropped. But it's better to do this > > > > > after the release of v6.2-rc1, when all pieces have fallen together. > > > > > > > > > Are you suggesting dropping it from defconfig? > > > > > > Yes, but not right now, as that would make it depend on my > > > renesas-drivers-for-v6.2 branch to keep them enabled. > > > ^^^ > > I was wondering if that's required by other platforms though. > > CONFIG_PM was added for VIRT machine and GPIOLIB for HiFive. > > Does that matter? They would still get it, as long as they use the > defconfig. > Confused, didnt you say about dropping it from defconfig... Cheers, Prabhakar
