Re: [PATCH v5 0/6] Add mmc-support for mt7986

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 26/10/2022 13:25, Ulf Hansson wrote:
On Tue, 25 Oct 2022 at 15:29, Frank Wunderlich <linux@xxxxxxxxx> wrote:

From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>

I've noticed the mtk-sd binding needs a bit more work get into a more
clean state.

There are 2 properties missing that maybe need to be added later or
dropped from devicetrees:
drv-type (which is used in mt8183-kukui.dtsi and set to <2>)
and
r_smpl (used in mt7622-rfb1.dts and mt7622-bananapi-bpi-r64.dts, both
times set to <1>)

i don't know their function and boundaries and i do not find them in
driver. I guess they are added by accident, so i removing them in the
patches 5+6.

v2:
- add compatible based binding
v3:
- solve "not" statement in binding and reorder if statements,drop mt8183
- added patches removing invalid properties (not in driver)
v4:
- squashed part 1 (compatible) and 3 (SoC specific clock config)
- new mt7986 clock bindings based on info from mtk
- re-add mt8183 reg boundary
v5:
- add fixes-tags to Patches 4+5 and reviewed-by to 6
- drop quotes from mt7986 clock-names from patch 2

Frank Wunderlich (3):
   arm64: dts: mediatek: mt2712e: swap last 2 clocks to match binding
   arm64: dts: mt8183: drop drv-type from mmc-node
   arm64: dts: mt7622: drop r_smpl property from mmc node

Nícolas F. R. A. Prado (1):
   dt-bindings: mmc: mtk-sd: Set clocks based on compatible

Sam Shih (2):
   dt-bindings: mmc: Add support for Mediatek MT7986
   mmc: mediatek: add support for MT7986 SoC

  .../devicetree/bindings/mmc/mtk-sd.yaml       | 149 ++++++++++++++----
  arch/arm64/boot/dts/mediatek/mt2712e.dtsi     |   6 +-
  .../dts/mediatek/mt7622-bananapi-bpi-r64.dts  |   1 -
  arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts  |   1 -
  .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi |   1 -
  drivers/mmc/host/mtk-sd.c                     |  14 ++
  6 files changed, 136 insertions(+), 36 deletions(-)

I have dropped the earlier two patches I have applied for MT7986 and
applied patch1, 2 and 6 from this series instead, thanks!


3, 4, 5 applied now thanks!



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux