Hi Jim! thanks for your patch! On Tue, Nov 8, 2022 at 10:29 AM Jim Liu <jim.t90615@xxxxxxxxx> wrote: > Add Nuvoton BMC sgpio driver support. > > Signed-off-by: Jim Liu <JJLIU0@xxxxxxxxxxx> > --- > Changes for v2: > - add prefix > - write the enum values in all capitals > - remove _init in npcm_sgpio_probe Overall this looks very good. But: > + u8 nin_sgpio; > + u8 nout_sgpio; These seem to be software constructs, for which you also add custom device tree bindings. The purpose seems to be an extra layer of protection, such as blocking a user from setting some GPIOs as input or output. I think you should just remove this, the GPIO driver is already sufficiently low level without the need of protecting the users from themselves. Yours, Linus Walleij
