On 08/11/2022 06:55, Dominique Martinet wrote: > Add devicetree binding to support defining a bluetooth device using the h4 > uart protocol > subject: drop second redundant "bindings" > This was tested with a NXP wireless+BT AW-XM458 module, but might > benefit others as the H4 protocol seems often used. > > Signed-off-by: Dominique Martinet <dominique.martinet@xxxxxxxxxxxxxxxxx> > --- > .../devicetree/bindings/net/h4-bluetooth.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/h4-bluetooth.yaml > > diff --git a/Documentation/devicetree/bindings/net/h4-bluetooth.yaml b/Documentation/devicetree/bindings/net/h4-bluetooth.yaml > new file mode 100644 > index 000000000000..5d11b89ca386 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/h4-bluetooth.yaml If the schema is for one specific device, then filename matching the compatible, so nxp,aw-xm458-bt.yaml... but I understand you want to describe here class of devices using H4 Bluetooth? Won't they need their own specific properties? > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/h4-bluetooth.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: H4 Bluetooth > + > +maintainers: > + - Dominique Martinet <dominique.martinet@xxxxxxxxxxxxxxxxx> > + > +description: > + H4 is a common bluetooth over uart protocol. Bluetooth UART > + For example, the AW-XM458 is a WiFi + BT module where the WiFi part is > + connected over PCI (M.2), while BT is connected over serial speaking > + the H4 protocol. Its firmware is sent on the PCI side. > + > +properties: > + compatible: > + enum: > + - nxp,aw-xm458-bt > + > + max-speed: true > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/clock/imx8mp-clock.h> > + > + uart1 { uart > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart1>; > + assigned-clocks = <&clk IMX8MP_CLK_UART1>; > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_80M>; Drop unrelated properties. > + status = "okay"; Drop status. > + fsl,dte-mode = <1>; > + fsl,uart-has-rtscts; Are these two related to this hardware? > + > + > + bluetooth { > + compatible = "nxp,aw-xm458-bt"; > + max-speed = <3000000>; > + }; > + }; Best regards, Krzysztof
