On 24/10/2022 18:42, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to hardware INTF indices. The driver discovers and binds > these ports not paying any care for the order of these items. Thus just > leave the reference to graph.yaml#/properties/ports and the description. > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- > .../bindings/display/msm/dpu-common.yaml | 52 +++++++++++++++++++ > .../bindings/display/msm/dpu-msm8998.yaml | 44 +--------------- > .../bindings/display/msm/dpu-qcm2290.yaml | 39 +------------- > .../bindings/display/msm/dpu-sc7180.yaml | 43 +-------------- > .../bindings/display/msm/dpu-sc7280.yaml | 43 +-------------- > .../bindings/display/msm/dpu-sdm845.yaml | 44 +--------------- > 6 files changed, 62 insertions(+), 203 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml > > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml > new file mode 100644 > index 000000000000..8ffbc30c6b7f > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml > @@ -0,0 +1,52 @@ > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Display DPU common properties > + > +maintainers: > + - Krishna Manikandan <quic_mkrishn@xxxxxxxxxxx> > + - Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > + - Rob Clark <robdclark@xxxxxxxxx> > + > +description: | > + Common properties for QCom DPU display controller. > + > +properties: > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + operating-points-v2: true > + opp-table: > + type: object > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + Contains the list of output ports from DPU device. These ports > + connect to interfaces that are external to the DPU hardware, > + such as DSI, DP etc. > + > + patternProperties: > + "^port@[0-9a-f]+$": > + $ref: /schemas/graph.yaml#/properties/port > + > + # at least one port is required > + required: > + - port@0 > + > +required: > + - compatible > + - reg > + - reg-names You do not have these properties here. Require only these properties which are defined here. Best regards, Krzysztof
