On Tue, Nov 08, 2022 at 02:18:15AM +0000, Bryan O'Donoghue wrote:
[..]
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 8ef0a9fe67dd..7199a86d2cbe 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -3801,6 +3801,39 @@ tlmm: pinctrl@f100000 {
> gpio-ranges = <&tlmm 0 0 181>;
> wakeup-parent = <&pdc>;
>
> + cam2_default: cam2-default {
Please add -state suffix to the pinctrl state nodes.
> + rst {
And please add -pins suffix to the subnodes thereof.
Regards,
Bjorn
