Re: [PATCH v2] arm64: allwinner: a64: add device tree for SoPine with clusterboard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2022-11-07星期一的 21:55 +0100,Renze Nicolai写道:
> Hello Krzysztof,
> 
> Thank you for your feedback! I've fixed the indentation and I've
> added 
> the compatible and model elements.

One small issue, I think the clusterboard has one node that comes with
eMMC, which is different from other nodes.

Should these have different DT's ?

> 
> Greetings,
> Renze Nicolai
> 
> 
> The Pine64 clusterboard needs a to have the tx delay changed to
> 500ps for ethernet to work. This solution was described by multiple
> people on the Pine64 forum years ago and nobody has submitted it.
> 
> Add a device tree for SoPine with the clusterboard.
> 
> Signed-off-by: Renze Nicolai <renze@xxxxxxxxx>
> ---
>   arch/arm64/boot/dts/allwinner/Makefile           |  1 +
>   .../allwinner/sun50i-a64-sopine-clusterboard.dts | 16
> ++++++++++++++++
>   2 files changed, 17 insertions(+)
>   create mode 100644 
> arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts
> 
> diff --git a/arch/arm64/boot/dts/allwinner/Makefile 
> b/arch/arm64/boot/dts/allwinner/Makefile
> index 6a96494a2e0a..15b011d1aaea 100644
> --- a/arch/arm64/boot/dts/allwinner/Makefile
> +++ b/arch/arm64/boot/dts/allwinner/Makefile
> @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += 
> sun50i-a64-pinephone-1.2.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb
> +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb
> diff --git 
> a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts 
> b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts
> new file mode 100644
> index 000000000000..f75325d43d76
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-
> clusterboard.dts
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +// Copyright (c) 2022 Renze Nicolai <renze@xxxxxxxxx>
> +
> +/dts-v1/;
> +
> +#include "sun50i-a64-sopine-baseboard.dts"
> +
> +/ {
> +       model = "SoPine with clusterboard";
> +       compatible = "pine64,sopine-clusterboard", "pine64,sopine",
> +                    "allwinner,sun50i-a64";
> +};
> +
> +&emac {
> +       allwinner,tx-delay-ps = <500>;
> +};





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux