On Mon, 7 Nov 2022 09:24:53 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 07/11/2022 03:42, lee wrote: > > On Thu, 3 Nov 2022 09:05:05 -0400 > > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > > > Hi, > > Thanks a lot for detailed comments and suggestions for > > revisions,there is one place where I have some doubts. > >> On 02/11/2022 23:04, lee wrote: > >>> Add YAML device tree binding for IMX519 CMOS image sensor, and > >>> the relevant MAINTAINERS entries. > >>> > >>> Signed-off-by: Lee Jackson <lee@xxxxxxxxxxx> > >> > >> Your From does not match fully SoB. > >> > >>> --- > >>> .../bindings/media/i2c/sony,imx519.yaml | 107 > >>> ++++++++++++++++++ MAINTAINERS | > >>> 9 ++ 2 files changed, 116 insertions(+) > >>> create mode 100644 > >>> Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > >>> > >>> diff --git > >>> a/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > >>> b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new > >>> file mode 100644 index 000000000000..9b6cda96f613 --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > >>> @@ -0,0 +1,107 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor > >>> + > >>> +maintainers: > >>> + - Lee Jackson <lee@xxxxxxxxxxx> > >>> + > >>> +description: |- > >>> + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image > >>> sensor > >>> + with an active array size of 4656H x 3496V. It is programmable > >>> through > >>> + I2C interface. The I2C address is fixed to 0x1A as per sensor > >>> data sheet. > >>> + Image data is sent through MIPI CSI-2, which is configured as > >>> either 2 or > >>> + 4 data lanes. > >>> + > >>> +properties: > >>> + compatible: > >>> + const: sony,imx519 > >>> + > >>> + reg: > >>> + description: I2C device address > >> > >> Skip description. > >> > >>> + maxItems: 1 > >>> + > >>> + clocks: > >>> + maxItems: 1 > >>> + > >>> + VDIG-supply: > >> > >> Use lower case names. > > > > Here we refer to other drivers (imx219), they are all uppercase, is > > lowercase mandatory? > > Lowercase is the convention. Just because some other driver used > uppercase is not really correct argument. If other driver has bug, you > also copy it? > > > Best regards, > Krzysztof > Hi, Thanks for your quick reply. I just want to refer to the driver that has passed the review, as a template, is there anything I can refer to? Do you have any good suggestions?
