On 2022/11/2, 11:56 PM, "Biju Das" <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > + parent_dev = of_find_device_by_node(np); > > + priv->clk = devm_clk_get_enabled(&parent_dev->dev, NULL); > > + if (IS_ERR(priv->clk)) > > + return dev_err_probe(dev, PTR_ERR(priv->clk), > > + "Couldn't get clock\n"); > What is the use case? > Is pwm configured by boot loader initially ? > Or > pwm configured by Linux, not by the bootloader initially? > Or > Driver needs to handle both cases? > Just asking, because you are turning on the clock unnecessarily here, > If you need to address all the use cases. If it is just first one, then > It is ok. Hi Biju, The driver want to handle all of the use cases. Can you tell me why turning on the clock is unnecessarily here? Thanks Best Regards, Billy Tsai