Hi, On Fri, Nov 4, 2022 at 7:28 AM Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> wrote: > > > On 04/11/2022 15:25, Doug Anderson wrote: > > Hi, > > > > On Fri, Nov 4, 2022 at 2:35 AM Konrad Dybcio > > <konrad.dybcio@xxxxxxxxxxxxxx> wrote: > >> > >> On 04/11/2022 07:19, Sheng-Liang Pan wrote: > >>> Change touchpad and touchscreen node for evoker > >>> Touchpad: SA461D-1011 > >>> Touchscreen: GT7986U > >> What's the reasoning? Were they changed post r0? Is r0 support > >> effectively dropped? > >> > >> The changes look ok, but I feel like this needs more of a comment in the > >> commit msg. > > As I understand it r0's toucscreen/touchpad were not right to start > > with. We are moving towards getting things upstream sooner and that > > means that hardware hasn't always been fully tested out. > > > > I certainly wouldn't object to a better commit message here, but in > > this case there are no real world users (yet) and thus nobody is > > really affected by this churn. ...so IMO if the series needs to be > > spun for some other reason then the commit message could be updated, > > but I wouldn't object to it landing as-is either. > > If there are no real (read: not-an-internal-devboard) devices using it, > then I > > agree, it's fine to merge as-is. I can confirm that. There are no evoker devices in the wild. -Doug
