On 04/11/2022 02:44, Sandor Yu wrote: > Add bindings for i.MX8MQ MHDP DisplayPort. > > Signed-off-by: Sandor Yu <Sandor.yu@xxxxxxx> Same comments as for HDMI bindings patch. Everywhere. > --- > .../display/bridge/cdns,mhdp-imx8mq-dp.yaml | 67 +++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml > new file mode 100644 > index 000000000000..06ed881247ea > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/display/bridge/cdns,mhdp-imx8mq-dp.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Cadence MHDP Displayport bridge > + > +maintainers: > + - Sandor Yu <Sandor.yu@xxxxxxx> > + > +description: > + The Cadence MHDP Displayport TX interface. > + > +properties: > + compatible: > + enum: > + - cdns,mhdp-imx8mq-dp > + > + reg: > + items: > + - description: > + Memory mapped base address and length of mhdptx apb registers. > + > + phys: > + description: > + phandle to the Displayport PHY. > + > + phy-names: > + items: > + - const: dpphy > + > + interrupts: > + items: > + - description: Hotplug detect interrupter for cable plugin event. > + - description: Hotplug detect interrupter for cable plugout event. > + > + interrupt-names: > + items: > + - const: plug_in > + - const: plug_out > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + A port node pointing to the output port of a display controller.. > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + mhdp: mhdp@32c00000 { dp@ > + compatible = "cdns,mhdp-imx8mq-dp"; > + reg = <0x32c00000 0x100000>; > + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "plug_in", "plug_out"; > + phys = <&dp_phy>; > + phy-names = "dpphy"; > + > + port { > + hdmi_in: endpoint { > + remote-endpoint = <&dcss_out>; > + }; > + }; > + }; Best regards, Krzysztof