Dear Nicolas, Thanks for the review. On Thu, 2022-11-03 at 17:03 -0400, Nícolas F. R. A. Prado wrote: > On Thu, Nov 03, 2022 at 11:26:05AM +0800, Nancy.Lin wrote: > [..] > > --- /dev/null > > +++ b/drivers/gpu/drm/mediatek/mtk_ethdr.h > > [..] > > +void mtk_ethdr_unregister_vblank_cb(struct device *dev); > > +void mtk_ethdr_enable_vblank(struct device *dev); > > +void mtk_ethdr_disable_vblank(struct device *dev); > > +#endif > > + > > As warned by git when applying the patch, you have an extra new line > at the end > here. > > Applying: drm/mediatek: add ETHDR support for MT8195 > .git/rebase-apply/patch:454: new blank line at EOF. > + > warning: 1 line adds whitespace errors. I will fix it. Thanks Nancy