On 29/10/2022 05:29, Saravanan Sekar wrote: > changes in v5: > - fixed commit message on v5-0002 and v5-0004 > > changes in v4: > - fixed attributes groups review comments in v3 > - added new bug fix patches v4-0007 and v4-0008 > > changes in v3: > - fixed dt_binding_check error > - fixed spelling usb->USB > > changes in v2: > - fixed spelling > - revert back probe to probe_new in mfd driver > > I do not see a cover letter, but FWIW, > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> This does not belong to the cover letter. Please add respective tags to patches, where applicable. If Andy gave Rb tag for entire patchset, add it to the patches. > for all patches except DT binding > Note, some of the comments regarding spelling were given, I believe > you are going to address them in v3. ...and this comment is from who? Andy? > > > add support for mp2733 Battery charger control driver for Monolithic > Power System's MP2733 chipset > > Saravanan Sekar (8): > iio: adc: mp2629: fix wrong comparison of channel > mfd: mp2629: fix failed to get iio channel by device name > iio: adc: mp2629: fix potential array out of bound access > power: supply: fix wrong interpretation of register value > mfd: mp2629: Add support for mps mp2733 battery charger > iio: adc: mp2629: restrict input voltage mask for mp2629 > power: supply: Add support for mp2733 battery charger > power: supply: mp2629: Add USB fast charge settings > > .../ABI/testing/sysfs-class-power-mp2629 | 16 ++ > drivers/iio/adc/mp2629_adc.c | 8 +- > drivers/mfd/mp2629.c | 7 +- > drivers/power/supply/mp2629_charger.c | 229 +++++++++++++++--- > include/linux/mfd/mp2629.h | 6 + Why do you Cc DT maintainers? > 5 files changed, 228 insertions(+), 38 deletions(-) > Best regards, Krzysztof