On 03/11/2022 08:35, Rob Herring wrote: > > On Thu, 03 Nov 2022 11:03:57 +0100, Andrej Picej wrote: >> Property "fsl,suspend-in-wait" suspends watchdog in "WAIT" mode which >> corresponds to Linux's Suspend-to-Idle S0 mode. If this property is not >> set and the device is put into Suspend-to-Idle mode, the watchdog >> triggers a reset after 128 seconds. >> >> Signed-off-by: Andrej Picej <andrej.picej@xxxxxxxxx> >> Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx> >> --- >> Changes in v3: >> - disallow the property for devices which don't support WDW bit >> functionality with .yaml DTS allOf:if:then scheme. >> >> Changes in v2: >> - add a commit message, >> - add a list of devices which support this functionality >> --- >> .../bindings/watchdog/fsl-imx-wdt.yaml | 33 +++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml:71:1: [error] duplication of key "allOf" in mapping (key-duplicates) > You already have there allOf, so: 1. Move the existing allOf *above* unevaluatedProperties:false (like in example-schema). 2. Drop the quotes around 'watchdog.yaml', when moving. 3. Add your pieces. All above in one commit. Best regards, Krzysztof
