On 03/11/2022 05:00, Liu Peibao wrote: > Add the newly added "skip-scan" property for child node. This we can see from the patch log. You need to say answer here to "Why". > > Signed-off-by: Liu Peibao <liupeibao@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/pci/loongson.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/loongson.yaml b/Documentation/devicetree/bindings/pci/loongson.yaml > index a8324a9bd002..5c2fe9bf2c78 100644 > --- a/Documentation/devicetree/bindings/pci/loongson.yaml > +++ b/Documentation/devicetree/bindings/pci/loongson.yaml > @@ -32,6 +32,13 @@ properties: > minItems: 1 > maxItems: 3 > > + child-node: What is "child-node"? > + type: object > + properties: > + skip-scan: > + description: avoid scanning this device. > + type: boolean Why? Isn't status for that? You also need additionalProperties: false/true, depending on what this child-node is... ...and add the case illustrating it in the example. Best regards, Krzysztof