On 2022/11/1 16:24, Weilong Chen wrote: > Add the new compatible for HiSilicon gpio controller driver. > > Signed-off-by: Weilong Chen <chenweilong@xxxxxxxxxx> Looks good to me, Reviewed-by: Yicong Yang <yangyicong@xxxxxxxxxxxxx> > --- > Change since v2: > - No change. > Link: https://lore.kernel.org/lkml/20221028022453.163186-2-chenweilong@xxxxxxxxxx/ > > Change since v1: > - Drop "Device Tree Bindings" and reg's description > - Move description in top-level description. > - Add gpio-cells to required > - Use additionalProperties and decimal numbers > - Use IRQ flags > - Use vendor,soc-ipblock format > Link: https://lore.kernel.org/lkml/20221026034219.172880-2-chenweilong@xxxxxxxxxx/ > > .../gpio/hisilicon,ascend910-gpio.yaml | 56 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/hisilicon,ascend910-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/hisilicon,ascend910-gpio.yaml b/Documentation/devicetree/bindings/gpio/hisilicon,ascend910-gpio.yaml > new file mode 100644 > index 000000000000..735d97d645a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/hisilicon,ascend910-gpio.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/hisilicon,ascend910-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HiSilicon common GPIO controller > + > +maintainers: > + - Jay Fang <f.fangjian@xxxxxxxxxx> > + > +description: > + The HiSilicon common GPIO controller can be used for many different > + types of SoC such as Huawei Ascend AI series chips. > + > +properties: > + compatible: > + const: hisilicon,ascend910-gpio > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + gpio-controller: true > + > + "#gpio-cells": > + const: 2 > + > + ngpios: > + minimum: 1 > + maximum: 32 > + > +required: > + - compatible > + - reg > + - interrupts > + - gpio-controller > + - "#gpio-cells" > + - ngpios > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + gpio@840d0000 { > + compatible = "hisilicon,ascend910-gpio"; > + reg = <0x840d0000 0x1000>; > + ngpios = <32>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index d42e34d1e8e2..74ac2e7a8e4b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9212,6 +9212,7 @@ HISILICON GPIO DRIVER > M: Jay Fang <f.fangjian@xxxxxxxxxx> > L: linux-gpio@xxxxxxxxxxxxxxx > S: Maintained > +F: Documentation/devicetree/bindings/gpio/hisilicon,ascend910-gpio.yaml > F: drivers/gpio/gpio-hisi.c > > HISILICON HIGH PERFORMANCE RSA ENGINE DRIVER (HPRE) >
