Hi AngeloGioacchino, On Wed, Nov 2, 2022 at 6:44 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote: > > > A "dmic-gpios" property is used for a mixer control to switch > > the dmic signal source between the Front and Rear Dmic. > > > > Refer to this one as an example, > > commit 3cfbf07c6d27 > > ("ASoC: qcom: sc7180: Modify machine driver for 2mic") > > > > +static const char * const dmic_mux_text[] = { > > + "FrontMic", > > + "RearMic", > > Why are the two words joined? > s/FrontMic/Front Mic/g > s/RearMic/Rear Mic/g > > Like that, we keep it consistent with the naming that was given in the commit > that you mentioned in the commit description. > > Regards, > Angelo Thank you for your review. Yes, you are correct, I should keep the string format consistent with the commit I mentioned in descriptions to avoid confusion. I will submit the next. Thanks. Regards.