On Mon, Oct 31, 2022 at 9:48 PM Marek Vasut <marex@xxxxxxx> wrote:
> CYW4373A0 is a Wi-Fi + Bluetooth combo device from Cypress.
> This chip is present e.g. on muRata 2AE module.
>
> This chip has additional quirk where the HCI command 0xfc45, used on
> older chips to switch UART clock from 24 MHz to 48 MHz, to support
> baudrates over 3 Mbdps, is no longer recognized by this newer chip.
> This newer chip can configure the 4 Mbdps baudrate without the need
> to issue HCI command 0xfc45, so add flag to indicate this and do not
> issue the command on this chip to avoid failure to set 4 Mbdps baud
> rate.
>
> It is not clear whether there is a way to determine which chip does
> and which chip does not support the HCI command 0xfc45, other than
> trial and error.
>
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
(...)
> +static struct bcm_device_data bcm4373a0_device_data = {
> + .no_uart_clock_set = true,
> +};
Shouldn't this be named cyw4373a0_device_data like the compatible
string and the device below it?
With that fixed:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Yours,
Linus Walleij
