On Tue, Oct 04, 2022 at 07:38:00PM +0200, Alexander Steffen wrote: > On 01.10.22 00:05, Rob Herring wrote: > > On Fri, 30 Sep 2022 18:51:13 +0200, Alexander Steffen wrote: > > > Several of the existing text files describe trivial TPMs, that fit > > > perfectly into the new trivial-tpms.yaml. Move them there. > > > > > > Signed-off-by: Alexander Steffen <Alexander.Steffen@xxxxxxxxxxxx> > > > --- > > > .../bindings/security/tpm/google,cr50.txt | 19 ---------- > > > .../bindings/security/tpm/tpm-i2c.txt | 26 -------------- > > > .../bindings/security/tpm/tpm_tis_mmio.txt | 25 ------------- > > > .../bindings/security/tpm/tpm_tis_spi.txt | 23 ------------ > > > .../bindings/security/tpm/trivial-tpms.yaml | 36 +++++++++++++++++++ > > > 5 files changed, 36 insertions(+), 93 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/security/tpm/google,cr50.txt > > > delete mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt > > > delete mode 100644 Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt > > > delete mode 100644 Documentation/devicetree/bindings/security/tpm/tpm_tis_spi.txt > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/security/tpm/trivial-tpms.example.dts:20.11-21: Warning (reg_format): /example-0/tpm@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) > > Documentation/devicetree/bindings/security/tpm/trivial-tpms.example.dts:42.11-24: Warning (reg_format): /example-1/tpm@57:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) > > Documentation/devicetree/bindings/security/tpm/trivial-tpms.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' > > Documentation/devicetree/bindings/security/tpm/trivial-tpms.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' > > Documentation/devicetree/bindings/security/tpm/trivial-tpms.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' > > Documentation/devicetree/bindings/security/tpm/trivial-tpms.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' > > Documentation/devicetree/bindings/security/tpm/trivial-tpms.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/patch/ > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > Any idea what is wrong here with reg_format? I just copied the existing > examples, so something was broken there before. The default bus is 1 address cell and 1 size cell. If you need something different, like I2C or SPI, you need to define the bus node in the example. This is explained in example-schema.yaml. Rob
