On Fri, Oct 28, 2022 at 07:12:55PM -0400, Krzysztof Kozlowski wrote: > Core schema does not define type of monitored-battery, so the schemas > are expected to reference proper type. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/power/supply/bq27xxx.yaml | 2 +- > .../devicetree/bindings/power/supply/ingenic,battery.yaml | 1 + > .../devicetree/bindings/power/supply/rohm,bd99954.yaml | 1 + > .../devicetree/bindings/power/supply/sc2731-charger.yaml | 2 +- > Documentation/devicetree/bindings/power/supply/sc27xx-fg.yaml | 3 ++- > 5 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml b/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml > index 65fc6049efc1..b04c86ed0f58 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml > +++ b/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml > @@ -59,6 +59,7 @@ properties: > description: integer, I2C address of the fuel gauge. > > monitored-battery: > + $ref: /schemas/types.yaml#/definitions/phandle > description: | > phandle of battery characteristics node. > The fuel gauge uses the following battery properties: > @@ -66,7 +67,6 @@ properties: > - charge-full-design-microamp-hours > - voltage-min-design-microvolt > Both or neither of the *-full-design-*-hours properties must be set. > - See Documentation/devicetree/bindings/power/supply/battery.yaml > > power-supplies: true > > diff --git a/Documentation/devicetree/bindings/power/supply/ingenic,battery.yaml b/Documentation/devicetree/bindings/power/supply/ingenic,battery.yaml > index 46527038bf22..8bdacc30e9d8 100644 > --- a/Documentation/devicetree/bindings/power/supply/ingenic,battery.yaml > +++ b/Documentation/devicetree/bindings/power/supply/ingenic,battery.yaml > @@ -27,6 +27,7 @@ properties: > const: battery > > monitored-battery: > + $ref: /schemas/types.yaml#/definitions/phandle We should not have a type definition multiple times for the same property. We need to add a common schema defining the type instead. Rob
