On Thu, Oct 27, 2022 at 10:42:13AM +0530, Vidya Sagar wrote: > Add support for ECAM aperture for Tegra234. > > Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx> > --- > .../devicetree/bindings/pci/nvidia,tegra194-pcie.yaml | 10 ++++++++-- > .../devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +- > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml > index 75da3e8eecb9..15cc2d2055bb 100644 > --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml > @@ -27,6 +27,7 @@ properties: > - nvidia,tegra234-pcie > > reg: > + minItems: 4 > items: > - description: controller's application logic registers > - description: configuration registers > @@ -35,13 +36,17 @@ properties: > available for software access. > - description: aperture where the Root Port's own configuration > registers are available. > + - description: aperture to access the configuration space through ECAM. > + This is applicable only for Tegra234. Is it really only Tegra234 or that's all you've tested or care about? For the former, I agree with Krzysztof. Rob
