Hi Rob, Thanks for your review, I will update them in V3. Thanks, Trevor On Mon, 2022-10-24 at 13:38 -0500, Rob Herring wrote: > On Fri, Oct 21, 2022 at 04:27:19PM +0800, Trevor Wu wrote: > > Add document for mt8188 board with mt6359. > > > > Signed-off-by: Trevor Wu <trevor.wu@xxxxxxxxxxxx> > > --- > > .../bindings/sound/mt8188-mt6359.yaml | 64 > > +++++++++++++++++++ > > 1 file changed, 64 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/mt8188- > > mt6359.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/mt8188- > > mt6359.yaml b/Documentation/devicetree/bindings/sound/mt8188- > > mt6359.yaml > > new file mode 100644 > > index 000000000000..9c493a6101ff > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml > > @@ -0,0 +1,64 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mt8188-mt6359.yaml*__;Iw!!CTRNKA9wMg0ARbw!wCd0tqzmjkRubNK5v9V8D6t_RuPYSb8AKqLPbfITprZT-I2UVgnFbm2N5Zzjr6W91A$ > > > > +$schema: > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!wCd0tqzmjkRubNK5v9V8D6t_RuPYSb8AKqLPbfITprZT-I2UVgnFbm2N5Zxc9ZZ9LA$ > > > > + > > +title: MediaTek MT8188 ASoC sound card driver > > Drop 'driver' > > > + > > +maintainers: > > + - Trevor Wu <trevor.wu@xxxxxxxxxxxx> > > + > > +description: > > + This binding describes the MT8188 sound card. > > Drop, the description doesn't add anything the title didn't say. > > > + > > +properties: > > + compatible: > > + enum: > > Only 1 entry, use 'const' > > > + - mediatek,mt8188_mt6359_evb > > s/_/-/ > > > + > > + model: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: User specified audio sound card name > > + > > + audio-routing: > > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > > + description: > > + A list of the connections between audio components. Each > > entry is a > > + sink/source pair of strings. Valid names could be the input > > or output > > + widgets of audio components, power supplies, MicBias of > > codec and the > > + software switch. > > + > > + mediatek,platform: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of MT8188 ASoC platform. > > + > > + mediatek,dptx-codec: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of MT8188 Display Port Tx codec node. > > + > > + mediatek,hdmi-codec: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of MT8188 HDMI codec node. > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - mediatek,platform > > + > > +examples: > > + - | > > + > > + sound: mt8188-sound { > > + compatible = "mediatek,mt8188_mt6359_evb"; > > + mediatek,platform = <&afe>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&aud_pins_default>; > > + audio-routing = > > + "Headphone", "Headphone L", > > + "Headphone", "Headphone R", > > + "AIN1", "Headset Mic"; > > + }; > > + > > +... > > -- > > 2.18.0 > > > >
