On Sat, Oct 29, 2022 at 07:59:36PM +0800, Weilong Chen wrote: > The HiSilicon I2C controller can be used on embedded platform, which > boot from devicetree. ... > +#include <linux/acpi.h> > +#include <linux/of.h> Why? ... > +#ifdef CONFIG_ACPI Why? ... > +#ifdef CONFIG_OF Why? ... > - .acpi_match_table = hisi_i2c_acpi_ids, > + .acpi_match_table = ACPI_PTR(hisi_i2c_acpi_ids), Why? ... > + .of_match_table = of_match_ptr(hisi_i2c_dts_ids), Why of_match_ptr()? -- With Best Regards, Andy Shevchenko
