On Fri, Oct 28, 2022 at 04:43:16PM -0500, Chris Morgan wrote:
> On Fri, Oct 28, 2022 at 02:14:11PM -0700, Dmitry Torokhov wrote:
> > Hi Chris,
> >
> > On Fri, Oct 28, 2022 at 03:26:36PM -0500, Chris Morgan wrote:
> > > +static void hyn_reset_proc(struct i2c_client *client, int delay)
> > > +{
> > > + struct hynitron_ts_data *ts_data = i2c_get_clientdata(client);
> > > +
> > > + gpiod_set_value_cansleep(ts_data->reset_gpio, 1);
> > > + mdelay(20);
> > > + gpiod_set_value_cansleep(ts_data->reset_gpio, 0);
> > > + if (delay)
> > > + mdelay(delay);
> >
> > Just wanted to ask - you do not really want to spin for 20+ msecs here,
> > right? I think changing mdelay() to msleep()/usleep() should be OK
> > throughout the driver...
>
> I just tested changing all instances of mdelay to msleep and msleep works
> just fine. Do you want me to resubmit or can you change that as well?
No need. I made a few additional changes and applied. Please take a look
in my 'next' branch and yell if something is wrong.
Thanks.
--
Dmitry
