On Thu, Oct 27, 2022 at 10:04:24AM -0400, Krzysztof Kozlowski wrote: > On 27/10/2022 10:03, Krzysztof Kozlowski wrote: > > On 27/10/2022 02:30, Manivannan Sadhasivam wrote: > >> Add VADC channels for measuring the on-chip die temperature and external > >> crystal osciallator temperature of PMK8280. > >> > >> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > >> --- > >> .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 18 ++++++++++++++++++ > >> 1 file changed, 18 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > >> index 6aa8cf6d9776..9ac5d5c22832 100644 > >> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > >> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > >> @@ -7,6 +7,7 @@ > >> /dts-v1/; > >> > >> #include <dt-bindings/gpio/gpio.h> > >> +#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h> > >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > >> > >> #include "sc8280xp.dtsi" > >> @@ -173,6 +174,23 @@ &pmk8280_pon_resin { > >> status = "okay"; > >> }; > >> > >> +&pmk8280_vadc { > >> + status = "okay"; > >> + > >> + pmk8280-die-temp@3 { > > > > die-temp@ > > Hm, wait, unless this is the die temperature of pmk8280? But then how > about pmic-die-temp? Yes, this is the die temperature of PMK8280, so "pmic-die-temp" makes sense. Thanks, Mani > > > Best regards, > Krzysztof > -- மணிவண்ணன் சதாசிவம்