On Fri, Oct 21, 2022 at 03:56:29PM +0200, Mattijs Korpershoek wrote: > Hi Chris, > > Thank you for your patch. > > On Mon, Oct 10, 2022 at 10:35, Chris Morgan <macroalpha82@xxxxxxxxx> wrote: > > > From: Chris Morgan <macromorgan@xxxxxxxxxxx> > > > > Add support for the Hynitron cst3xx controller found on devices such > > as the Anbernic RG353P and RG353V (the Hynitron CST340). This driver > > was built from sources provided by Hynitron to Anbernic (possibly > > via Rockchip as an intermediary) and marked as GPLv2 in the code. > > This driver was written strictly for the cst3xx series, but in > > most places was left somewhat generic so support could be easily > > added to other devices in the future. > > > > Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> > > --- > > drivers/input/touchscreen/Kconfig | 12 + > > drivers/input/touchscreen/Makefile | 1 + > > drivers/input/touchscreen/hynitron_cstxxx.c | 508 ++++++++++++++++++++ > > 3 files changed, 521 insertions(+) > > create mode 100644 drivers/input/touchscreen/hynitron_cstxxx.c > > > > diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig > > index 2d70c945b20a..9a9528e59c36 100644 > > --- a/drivers/input/touchscreen/Kconfig > > +++ b/drivers/input/touchscreen/Kconfig > > @@ -422,6 +422,18 @@ config TOUCHSCREEN_HYCON_HY46XX > > To compile this driver as a module, choose M here: the > > module will be called hycon-hy46xx. > > > > +config TOUCHSCREEN_HYNITRON_CSTXXX > > + tristate "Hynitron touchscreen support" > > + depends on I2C > > Since we include linux/of.h, I think we should also add: > depends on OF I think the driver should easily work on a non-OF system (ACPI for example). Including OF is fine, but I'd rather we did not use of_device.h and instead used device_get_match_data() from property.h Thanks. -- Dmitry
