On 28/10/2022 12:52, Sasha Finkelstein wrote: > Apple SoCs such as the M1 contain a PWM controller used > among other things to control the keyboard backlight. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@xxxxxxxxx> > --- > .../devicetree/bindings/pwm/pwm-apple.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-apple.yaml b/Documentation/devicetree/bindings/pwm/pwm-apple.yaml > new file mode 100644 > index 000000000000..39dc32e00a3f > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-apple.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/pwm-apple.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple FPWM controller > + > +maintainers: > + - asahi@xxxxxxxxxxxxxxx > + - Sasha Finkelstein <fnkl.kernel@xxxxxxxxx> > + > +description: |+ > + PWM controller used for keyboard backlight on ARM Macs > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t8103-fpwm > + - apple,t6000-fpwm > + - apple,t8112-fpwm > + - const: apple,s5l-fpwm Missing blank line. > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + "#pwm-cells": > + const: 2 > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + pwm: fpwm@235044000 { > + compatible = "apple,s5l-fpwm"; As Rob's bot pointed out, this does not match the bindings so you did not test them before sending :( Best regards, Krzysztof
