Hi Mark Brown, On Sat, Oct 29, 2022 at 12:17 AM Mark Brown <broonie@xxxxxxxxxx> wrote: > Also do we really need the of_property_read_bool() there? I'd have > expected that devm_gpiod_get_optional() would be handling that for us. You are right, it is unnecessary to use of_property_read_bool() there , I will remove and send the v2 version, thank you.