On Fri, Oct 28, 2022 at 08:09:11AM +0200, Johan Hovold wrote: > On Thu, Oct 27, 2022 at 10:15:45PM -0400, Krzysztof Kozlowski wrote: > > On 24/10/2022 06:06, Johan Hovold wrote: > > > The current QMP USB PHY bindings are based on the original MSM8996 PCIe > > > PHY binding which provided multiple PHYs per IP block and these in turn > > > were described by child nodes. > > > > > > The QMP USB PHY block only provide a single PHY and the remnant child > > > node does not really reflect the hardware. > > > > > > The original MSM8996 binding also ended up describing the individual > > > register blocks as belonging to either the wrapper node or the PHY child > > > nodes. > > > > > > > (...) > > > > > then: > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml > > > new file mode 100644 > > > index 000000000000..95ee81d782f9 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml > > > > Filename based on compatible, so in this case > > "qcom,sc8280xp-qmp-usb3-uni-phy.yaml", unless it's like the PCI case? > > Yes, you're right. Thanks for catching that. This should be the only > sc8280xp USB PHY compatible so the file name should be updates as you > suggested. Looks like I missed the '3' in 'usb3' in the previous patch as well. Johan
