RE: [PATCH v2 2/5] iio: temperature: ltc2983: make bulk write buffer DMA-safe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: Sunday, October 23, 2022 2:43 PM
> To: Cosmin Tanislav <demonsingur@xxxxxxxxx>
> Cc: Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; Lars-Peter Clausen
> <lars@xxxxxxxxxx>; Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>;
> Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Tanislav, Cosmin
> <Cosmin.Tanislav@xxxxxxxxxx>
> Subject: Re: [PATCH v2 2/5] iio: temperature: ltc2983: make bulk write buffer
> DMA-safe
> 
> [External]
> 
> On Thu, 20 Oct 2022 12:02:54 +0300
> Cosmin Tanislav <demonsingur@xxxxxxxxx> wrote:
> 
> > From: Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>
> >
> > regmap_bulk_write() does not guarantee implicit DMA-safety,
> > even though the current implementation duplicates the given
> > buffer. Do not rely on it.
> >
> > Fixes: f110f3188e56 ("iio: temperature: Add support for LTC2983")
> > Signed-off-by: Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>
> LGTM.
> 
> As you right observed this is only sort of a fix because right now we
> are fine anyway, so in the interests of getting the rest of the series
> upstream quicker I'll take this one for the next merge window along
> with the rest of the set.
> 
> Thanks,
> 
> Jonathan
> 

Not sure if you already applied this... Anyways:

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux