Re: [PATCH v1 2/8] arm64: dts: verdin-imx8mm: verdin-imx8mp: improve include notation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shawn

On Thu, 2022-09-22 at 18:29 +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
> 
> Improve include notation. Usually only dtsi files from the same location
> are included with an absolute path in quotes. Others should use a
> relative path enclosed in angle brackets.
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
> ---
> 
>  arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 4 ++--
>  arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 3 ++-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-
> verdin.dtsi
> index b379c461aa13..a749d063c367 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> @@ -3,8 +3,8 @@
>   * Copyright 2022 Toradex
>   */
>  
> -#include "dt-bindings/phy/phy-imx8-pcie.h"
> -#include "dt-bindings/pwm/pwm.h"
> +#include <dt-bindings/phy/phy-imx8-pcie.h>
> +#include <dt-bindings/pwm/pwm.h>
>  #include "imx8mm.dtsi"
>  
>  / {
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-
> verdin.dtsi
> index 360be51a3527..ee4231d138fe 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -3,7 +3,8 @@
>   * Copyright 2022 Toradex
>   */
>  
> -#include "dt-bindings/pwm/pwm.h"
> +#include <dt-bindings/phy/phy-imx8-pcie.h>

Sorry, I just noticed that above line slipped in from patch 6. However, at least it should not hurt as that
header file does indeed exist since quite a while when PCIe support got merged for the Mini.

> +#include <dt-bindings/pwm/pwm.h>
>  #include "imx8mp.dtsi"
>  
>  / {

Cheers

Marcel




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux