On 22/10/2022 12:27, Aidan MacDonald wrote: > This is a new per-DAI property used to specify the clock ID argument > to snd_soc_dai_set_sysclk(). You did no show the use of this property and here you refer to some specific Linux driver implementation, so in total this does no look like a hardware property. You also did not explain why do you need it (the most important piece of commit msg). > > Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx> > --- > Documentation/devicetree/bindings/sound/simple-card.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml > index ed19899bc94b..cb7774e235d0 100644 > --- a/Documentation/devicetree/bindings/sound/simple-card.yaml > +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml > @@ -57,6 +57,12 @@ definitions: > single fixed sampling rate. > $ref: /schemas/types.yaml#/definitions/flag > > + system-clock-id: > + description: | > + Specify the clock ID used for setting the DAI system clock. With lack of explanation above, I would say - use common clock framework to choose a clock... Best regards, Krzysztof
