On 21/10/2022 18:58, Daniel Golle wrote: > On Fri, Oct 21, 2022 at 05:23:38PM -0500, Rob Herring wrote: >> On Fri, Oct 21, 2022 at 04:25:18PM +0100, Daniel Golle wrote: >>> Add new compatible string for MT7986 PWM. >>> >>> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt >>> index 554c96b6d0c3e0..6f4e60c9e18b81 100644 >>> --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt >>> +++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt >>> @@ -8,6 +8,7 @@ Required properties: >>> - "mediatek,mt7623-pwm": found on mt7623 SoC. >>> - "mediatek,mt7628-pwm": found on mt7628 SoC. >>> - "mediatek,mt7629-pwm": found on mt7629 SoC. >>> + - "mediatek,mt7986-pwm": found on mt7986 SoC. >> >> This version of the PWM h/w is not compatible with any of the existing >> chips? If it is, it should have a fallback compatible. > > No, it is unique because it comes with just 2 PWM channels. > Otherwise the driver behaves just like for MT8183 (4 channels) or > MT8365 (3 channels) which also got distinct compatible strings. Then something would be here compatible. E.g. If you bound MT8183 with mt7986-pwm compatible, would you get working device with two channels? If so, they are compatible. Best regards, Krzysztof
