On 21/10/2022 08:45, Maxime Chevallier wrote: > The Qualcomm IPQESS controller is a simple 1G Ethernet controller found > on the IPQ4019 chip. This controller has some specificities, in that the > IPQ4019 platform that includes that controller also has an internal > switch, based on the QCA8K IP. Thank you for your patch. There is something to discuss/improve. > diff --git a/MAINTAINERS b/MAINTAINERS > index 5c6ce094e55e..46fdd3c523c5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -17037,6 +17037,12 @@ L: netdev@xxxxxxxxxxxxxxx > S: Maintained > F: drivers/net/ethernet/qualcomm/emac/ > > +QUALCOMM IPQESS ETHERNET DRIVER > +M: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx> > +L: netdev@xxxxxxxxxxxxxxx > +S: Maintained > +F: drivers/net/ethernet/qualcomm/ipqess/ Add also bindings. > + > QUALCOMM ETHQOS ETHERNET DRIVER > M: Vinod Koul <vkoul@xxxxxxxxxx> > R: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig > index a4434eb38950..a723ddbea248 100644 > --- a/drivers/net/ethernet/qualcomm/Kconfig > +++ b/drivers/net/ethernet/qualcomm/Kconfig > @@ -60,6 +60,17 @@ config QCOM_EMAC > low power, Receive-Side Scaling (RSS), and IEEE 1588-2008 > Precision Clock Synchronization Protocol. > > +config QCOM_IPQ4019_ESS_EDMA > + tristate "Qualcomm Atheros IPQ4019 ESS EDMA support" > + depends on OF I think this is present only on systems where Qualcomm IPQ4019 SoCs is the main SoC (AP)? If so, I propose not to offer this to non-Qualcomm SoC builds, because they cannot use it and it makes life of distro-vendors configurators difficult: depends on ARCH_QCOM || COMPILE_TEST > + select PHYLINK > + help > + This driver supports the Qualcomm Atheros IPQ40xx built-in > + ESS EDMA ethernet controller. > + > + To compile this driver as a module, choose M here: the > + module will be called ipqess. > + > source "drivers/net/ethernet/qualcomm/rmnet/Kconfig" Best regards, Krzysztof
